Skip to content

Added date configuration to Schedule & Details settings page - #29879

Closed
jbcurtin wants to merge 1 commit into
openedx:masterfrom
open-craft:jbcurtin/bb-5429-date-configuration
Closed

Added date configuration to Schedule & Details settings page#29879
jbcurtin wants to merge 1 commit into
openedx:masterfrom
open-craft:jbcurtin/bb-5429-date-configuration

Conversation

@jbcurtin

@jbcurtin jbcurtin commented Feb 7, 2022

Copy link
Copy Markdown

Description

Adds the ability to configure Schedule & Details settings page with the ability to show dd/mm/yyyy format. Default setting maintains existing behavior and doesn't introduce anything new.
Why:
Some areas of the world operate with the day-first: dd/mm/yyyy rather than mm/dd/yyyy.

Useful information to include:

Testing instructions

  • Initialize devstack to use branch
  • Open file cms/env/common.py and find SCHEDULE_DETAIL_FORMAT. Alter the string value from mm/dd/yyyy -> dd/mm/yyyy.
  • Load Schedule & Details page ( http://localhost:18010/settings/details/course-v1:edX+DemoX+Demo_Course )
  • Scroll down to Course Schedule. Notice the placeholder format in the date-fields.
  • Click in various date-fields and make sure the dates are correctly applied in format: dd/mm/yyyy

Deadline

None as of now.

@openedx-webhooks

openedx-webhooks commented Feb 7, 2022

Copy link
Copy Markdown

Thanks for the pull request, @jbcurtin! I've created OSPR-6439 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@jbcurtin
jbcurtin changed the base branch from open-release/lilac.master to master February 7, 2022 07:39
@jbcurtin jbcurtin changed the title Added date configuration to Schedule & Details settings page Do not merge: Added date configuration to Schedule & Details settings page Feb 7, 2022
@jbcurtin
jbcurtin force-pushed the jbcurtin/bb-5429-date-configuration branch from 48880c3 to 5952be3 Compare February 7, 2022 07:51
farhaanbukhsh
farhaanbukhsh reviewed Feb 7, 2022
View reviewed changes
Comment thread cms/envs/common.py
# Supported formats
# mm/dd/yyyy
# dd/mm/yyyy
'DETAIL_SCHEDULE_FORMAT': 'mm/dd/yyyy'

@farhaanbukhsh farhaanbukhsh Feb 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'DETAIL_SCHEDULE_FORMAT': 'mm/dd/yyyy'
'DETAIL_SCHEDULE_FORMAT': 'MM/DD/YYYY'

@jbcurtin jbcurtin changed the title Do not merge: Added date configuration to Schedule & Details settings page Added date configuration to Schedule & Details settings page Feb 7, 2022
@jbcurtin jbcurtin mentioned this pull request Feb 7, 2022
Closed
@natabene

natabene commented Feb 7, 2022

Copy link
Copy Markdown
Contributor

@jbcurtin Thank you for the contribution! Once you have signed our Contributor Agreement and it has been processed, you will receive a confirmation via email from our Legal team. We then will be able to review this and all your future code contributions.

@natabene

natabene commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

@jbcurtin Have you had a chance to sign the agreement? Please let me know if I can help.

@natabene

natabene commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

@jbcurtin We have not heard from you in a while, so I will go ahead and close this PR for now. Should you decide to pursue this again, please feel free to re-open.

@natabene natabene closed this Apr 1, 2022
@openedx-webhooks

openedx-webhooks commented Apr 1, 2022

Copy link
Copy Markdown

@jbcurtin Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@farhaanbukhsh farhaanbukhsh mentioned this pull request Apr 25, 2022
Closed
@0x29a
0x29a deleted the jbcurtin/bb-5429-date-configuration branch September 21, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farhaanbukhsh farhaanbukhsh farhaanbukhsh left review comments

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbcurtin @openedx-webhooks @natabene @farhaanbukhsh